Philippe M. Chiasson wrote:
if $Apache::Server::StrictPerlSections is true, syntax error in <Perl >
sections aborts server startup, otherwise, you only get a warning.
[...]
+#define MP_STRICT_PERLSECTIONS_SV \
+perl_get_sv("Apache::Server::StrictPerlSections", FALSE)

perlapi.pod says that perl_ should be dropped:


      get_sv  Returns the SV of the specified Perl scalar.  If "create" is
               set and the Perl variable does not exist then it will be cre-
               ated.  If "create" is not set and the variable does not exist
               then NULL is returned.

NOTE: the perl_ form of this function is deprecated.

SV* get_sv(const char* name, I32 create)


MP_CMD_SRV_DECLARE(perldo)
{
@@ -327,6 +329,7 @@
const char *package_name = NULL;
int status = OK;
AV *args = Nullav;
+ SV *sv;
#ifdef USE_ITHREADS
MP_dSCFG(s);
pTHX;
@@ -369,7 +372,16 @@
eval_pv(arg, FALSE);
if (SvTRUE(ERRSV)) {
- return SvPVX(ERRSV);

could move 'SV *sv' in here


+ if ((sv = MP_STRICT_PERLSECTIONS_SV) && SvTRUE(sv)) {

the same perlapi entry says, that NULL is returned if get_sv(...,FALSE) doesn't find that variable. So shouldn't it check:


if ((sv = MP_STRICT_PERLSECTIONS_SV) != NULL )

or is it essentially the same?

otherwise +1

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to