On Sun, 2003-03-02 at 12:31, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > Another <Perl > section backwards-compatibility item on the TODO list. > > > > Perl $Apache::Server::SaveConfig = 1 > > > > in httpd.conf will retain all the code of the <Perl > sections, otherwise, > > the whole namespace is whiped (modperl_clear_symtab) stolen from mp1 > > Great, Philippe! A few minor comments:
Ack and will resubmit later today. Thanks for the extra pair of
ever-vigilant eyes ;-)
>
> > Index: src/modules/perl/modperl_cmd.c
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_cmd.c,v
> > retrieving revision 1.38
> > diff -u -I'$Id' -I'$Revision' -r1.38 modperl_cmd.c
> > --- src/modules/perl/modperl_cmd.c 26 Feb 2003 09:32:54 -0000 1.38
> > +++ src/modules/perl/modperl_cmd.c 27 Feb 2003 04:58:27 -0000
> > @@ -318,6 +318,8 @@
> > #define MP_DEFAULT_PERLSECTION_PACKAGE "Apache::ReadConfig"
> > #define MP_STRICT_PERLSECTIONS_SV \
> > get_sv("Apache::Server::StrictPerlSections", FALSE)
>
> s/^/ /; (i know I've missed that on your previous one ;)
>
> > +#define MP_PERLSECTIONS_SAVECONFIG_SV \
> > +get_sv("Apache::Server::SaveConfig", FALSE)
>
> s/^/ /;
> [...]
> > + if(symtab) {
>
> s/if\(/if (/
>
> [...]
>
> > Index: src/modules/perl/modperl_util.h
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_util.h,v
> > retrieving revision 1.38
> > diff -u -I'$Id' -I'$Revision' -r1.38 modperl_util.h
> > --- src/modules/perl/modperl_util.h 23 Jan 2003 00:31:28 -0000 1.38
> > +++ src/modules/perl/modperl_util.h 27 Feb 2003 04:58:38 -0000
> > @@ -126,4 +126,6 @@
> >
> > SV *modperl_perl_gensym(pTHX_ char *pack);
> >
> > +void modperl_clear_symtab(pTHX_ HV *symtab);
> > +
> > #endif /* MODPERL_UTIL_H */
>
> also needs to be added to
> xs/tables/current/ModPerl/FunctionTable.pm
>
> Finally, for this feature we actually could have a test, with a simple regex
> just to test that the config is actually there.
True, I will do that also.
>
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.com
>
>
signature.asc
Description: This is a digitally signed message part
