On Tue, 18 Mar 2003 16:41:17 +1100, "Stas Bekman" <[EMAIL PROTECTED]> said:>
Kermit Tensmeyer wrote:
I looked thru the archives, i didn't see this from before.. so if this is repetious I apoligize.
make install fails because APACHE_INCLUDEDIR = " " which is because (....) because two macros inside the call to ModPerl::MM::WriteMakefile return empty strings. (hey I'm trying to cut to the chase as quickly as possible)
macro => { APACHE_INCLUDEDIR => $build->apxs('-q' => 'includedir'), }
That should be fixed now in cvs. Thank you for the detailed report.
I've failed to catch it earlier as I was building with MP_APXS and not MP_AP_PREFIX.
yes there are some changes now Makefile.PL uses the macro MODPERL_AP_INCLUDEDIR => $build->apxs('-q' => 'INCLUDEDIR'),
and
modperl_xs_h_install: @$(MKPATH) $(MODPERL_AP_INCLUDEDIR) $(CP) $(MODPERL_XS_H_FILES) $(MODPERL_AP_INCLUDEDIR)
is still broken because MODPERL_AP_INCLUDIR is empty and since $build->apxs('-q' => 'INCLUDEDIR') still returns an empty string
but this is the -only- occurance of $build->apxs left in Makefile.PL
the same problem shows up in src/modules/perl/Makefile.modperl as the targets MODPERL_AP_INCLUDEDIR and MODPERL_AP_LIBEXECDIR
as I see it there are two alternatives ( get $build->apxs to work properly _or_ parse $build->{dir}/build/config_vers.mk for the variables)
Definitely fix the apxs() function, because it hides the differences for when the actual apxs script is used or not, and it already parses for variables when the apxs script is not used.
is there any other use for Apache::Build::apxs ?
It's used a lot internally, mainly in lib/Apache/Build.pm. You can grep for it to see for yourself.
Any chance you can trace why this doesn't work for you? I can't seem to reproduce the problem here.
We should also probably assert in Makefile.PL if $build->apxs('-q' => 'INCLUDEDIR') fails, rather than silently move on.
Thanks.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
