The punch line is that most 3rd party Apache:: modules's Makefile.PL will look as simple as:
require ModPerl::MM; ModPerl::MM::WriteMakefile( NAME => "Apache::Peek", VERSION_FROM => "Peek.pm", );
no matter if they use XS or not.
I'd suggest the following patch to make the above assertion true - it adds the 'macro' option to the default list. without it, installations are not automatically intelligent about Apache2/ installations.
otherwise, nice work stas - it works like a charm.
--Geoff
Index: MM.pm
===================================================================
RCS file: /home/cvspublic/modperl-2.0/lib/ModPerl/MM.pm,v
retrieving revision 1.27
diff -u -r1.27 MM.pm
--- MM.pm 24 Mar 2003 05:43:51 -0000 1.27
+++ MM.pm 24 Mar 2003 13:37:52 -0000
@@ -99,17 +99,18 @@
}
}-my @default_opts = qw(CCFLAGS LIBS INC OPTIMIZE LDDLFLAGS TYPEMAPS);
+my @default_opts = qw(CCFLAGS LIBS INC OPTIMIZE LDDLFLAGS TYPEMAPS macro);
my @default_dlib_opts = qw(OTHERLDFLAGS);
my $b = build_config();
my %opts = (
- CCFLAGS => sub { $b->perl_ccopts . $b->ap_ccopts },
- LIBS => sub { join ' ', $b->apache_libs, $b->modperl_libs },
- INC => sub { $b->inc; },
- OPTIMIZE => sub { $b->perl_config('optimize'); },
- LDDLFLAGS => sub { $b->perl_config('lddlflags'); },
- TYPEMAPS => sub { $b->typemaps; },
- OTHERLDFLAGS => sub { $b->otherldflags; },
+ CCFLAGS => sub { $b->perl_ccopts . $b->ap_ccopts },
+ LIBS => sub { join ' ', $b->apache_libs, $b->modperl_libs },
+ INC => sub { $b->inc; },
+ OPTIMIZE => sub { $b->perl_config('optimize'); },
+ LDDLFLAGS => sub { $b->perl_config('lddlflags'); },
+ TYPEMAPS => sub { $b->typemaps; },
+ OTHERLDFLAGS => sub { $b->otherldflags; },
+ macro => sub { { MOD_INSTALL => ModPerl::MM::mod_install(), } },
);sub get_def_opt {
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
