Randy Kobes wrote:
On Mon, 31 Mar 2003, Stas Bekman wrote:


Randy Kobes wrote:


- First off, in xs/modperl.def, an entry for MP_debug_level
appears, which the linker can't find when building mod_perl.so.
For Win32, src/modules/perl/modperl_log.h sets MP_debug_level
to modperl_debug_level(), which is in xs/modperl.def. This diff:

Ah, I guess since I've used berok on aix this didn't trigger the problem. I've applied a similar fix adding this symbol only when MP_DEBUG=1. Does this work on windows?


That works when not building with MP_DEBUG=1, but if you do
enable MP_DEBUG, it can't find the MP_debug_level symbol in
modperl.def when building mod_perl.lib. Since for WIN32
MP_debug_level is defined to be modperl_debug_level, shouldn't
MP_debug_level be skipped in modperl.def? modperl_debug_level
does occur in modperl.def.

Ah, of course, I've committed the fix that ensures that. Other platforms may need that symbol no matter what MP_DEBUG setting is.
Thanks Randy.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to