The problem pointed out by Ken is that it would be nice to be able to call
Apache->request($hr);
So that later call to Apache->request (by other modules) would return the subclassed object.
it would not only be nice, request() is documented to behave this way :)
Well, the following patch does just that. Seems fine to me but I'd like to get a few more eyeballs on this one.
nice work philippe :)
gozer++
the only thing that concerns me here is the stability this may take away from the 1.0 tree for very little value - although stuff like Apache::Filter might benefit from this feature, I'm not sure that adding it now is worth it, since any interested modules are becoming deprecated in 2.0.
/me has the same concern. May be keep it in the STATUS file as an available patch. After all there was only one request for this feature. If the patch is available those who want it can try it and if tested enough, can enter 1.29.
regarding the patch. why do you keep both IV and SV? Also looks like you mix usages of NULL and Nullsv for SV* values. Otherwise looks good.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
