On Thu, 2003-07-03 at 21:52, Randy Kobes wrote: > On Thu, 3 Jul 2003, Issac Goldstand wrote: > > > Dare I hope that Randy managed to commit the patch that lets > > mp-1.28 build on win32 with activestate perl 5.8.0? It was so > > close to working and it's a major platform release, IMHO... > > (Randy: I'm toying with the patch you sent me...) > > No, I didn't commit it. The patch shouldn't affect any other > platform, but before committing it it would be good to, first of > all, see if someone can see a better way and/or can see if > there's something wrong in principle with it, and secondly, to > get some further testing of it on other machines and also outside > of the mod_perl tests (which all pass). For example, it would be > interesting to see if the problems Steve finds with the > t/request.t tests on 5.8.0 without LARGE_FILES support are still > there - the mod_perl tests I did were without libapreq, so the > t/request.t (and t/cookie.t) tests were skipped.
Absolutely! And Randy, as soon as you are happy with both a patch and satisfactory test results (in your opinion), I'd say commit++ Gozer out.
signature.asc
Description: This is a digitally signed message part
