Hi,
   With mod_perl 1 on Win32, it would be handy for some 3rd party
modules to have available the built mod_perl.lib in some system
location (right now, the source directory used for building, as
recorded in Apache::MyConfig, is used for that location, but
people may delete the source directory later). One possibilty is
to copy mod_perl.lib to the system Apache/libexec directory, as
in the following:
======================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl/Makefile.PL,v
retrieving revision 1.214
diff -u -r1.214 Makefile.PL
--- Makefile.PL 2 Jul 2003 15:57:53 -0000       1.214
+++ Makefile.PL 5 Jul 2003 16:35:21 -0000
@@ -370,7 +370,7 @@
     (-d "$fixed_apsrc/src/include" ? $fixed_apsrc . '/src' :
      die "Cannot find the Apache include directory under $fixed_apsrc");
   $win32_auto = 1;
-  if (not defined $win32_args{INSTALL_DLL}) {
+  unless ($win32_args{INSTALL_DLL}) {
     my $w32_ap_mod = $fixed_apsrc . '/modules';
     $win32_args{INSTALL_DLL} = $w32_ap_mod if -d $w32_ap_mod;
   }
@@ -1371,6 +1371,12 @@
        $win32_args{INSTALL_DLL} .
          ($win32_args{APACHE_VERS} < 1315 ?
           '/ApacheModulePerl.dll' : '/mod_perl.so');
+        if (-d "$win32_args{APACHE_SRC}/libexec") {
+          my $libexec = win32_fix_path($win32_args{APACHE_SRC}) . '/libexec';
+          $string .= sprintf qq{\n\t\$(CP) "%s" "%s"},
+            "$win32_path{MODPERL_LIB}/mod_perl.lib",
+              $libexec . '/mod_perl.lib';
+        }
       }
       return $string;
     }
==============================================================
Does that seem reasonable? Or would it be better to copy
it under the Perl tree, as is currently done with the
header files?

Also, it might be nice to clean up t/TEST.win32 used to run the
Win32 tests - make it run under 'use strict', put in a few more
checks for errors, etc. There's also a couple of potential
problems with it that could be fixed at the same time - when
searching for Apache.exe, make sure to not look in floppy disc
drives or CDROMS (otherwise, the system will prompt you to put a
disc in the drive, if it's empty), and also make sure the
Apache.exe found is version 1.3. I have a diff for these, but
it's quite long (I also deleted a bunch of blank lines in the
current version). Would it be OK if I just committed it, and
anyone interested could comment on that version? Thanks.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to