Matt Sergeant wrote:
On Thu, 17 Jul 2003, Stas Bekman wrote:


The problem is that it has to be first for the mod_perl test suite. Since
different projects have different needs, what I provided a way to have
includes to be added first or last. Geoff has given the answer, and it's
documented here:

http://perl.apache.org/docs/general/testing/testing.html#Extending_Configuration_Setup


Yes, that works. Is there any reason (besides tuits) that these docs
aren't in the POD?

You mean it's not documented in the Apache::Test manpages? It's written in pod, see: modperl-docs/src/docs/general/testing/testing.pod.


Also another gripe - wouldn't it be nicer to skip tests if httpd can't be
found, rather than fail them? Or perhaps prompt to provide a path to
httpd? And that value could be stored in t/TEST, so I don't have to set an
environment variable every time I run the tests.

If this actually is available I couldn't find it documented in the POD,
but more importantly, when httpd can't be found the error should say
something about how you can fix the problem (setting env vars, or passing
a flag, or just pointing to the right docs).

Agreed, that at this moment this is the weak side of Apache::Test. I thought that once every Apache module will start using Apache::Test people will set APACHE and/or APXS env vars in their ~/.login files and everything will just work.


The setting is already set in t/TEST if you autogenerate it. For example if you run:

Apache-Test> perl Makefile.PL -apxs /home/stas/httpd/prefork/bin/apxs
generating script t/TEST
Writing Makefile for Apache::Test

it adds to t/TEST:

%Apache::TestConfig::Argv = qw(apxs /home/stas/httpd/prefork/bin/apxs);

So you need to pass -apxs or to have:

APXS=foo perl Makefile.PL

only during the config phase.

As for the prompt, it's probably only useful from within CPAN shell. From the command line it's much better to have people pass this argument to Makefile.PL. Again if everybody sets their APXS env var in ~/.login, then all the future testing using Apache::Test just works. Do you think it's not worth to make people do this instead having an annoying prompt on each module build?

As for the making the error message more useful, you are correct. This needs to be improved.

Again, sorry for no patch. I'll buy you a beer in Paris instead, Stas.

;)


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to