Hi,
On Win32, it would be handy in debugging to generate pdb
files, which contain symbol information (Apache and ActiveState
now do this by default in their source distributions). Below is
a diff that does this when MP_DEBUG is enabled; the pdb files are
placed in the same directory as the correspoding .dll (.so)
files, and for mod_perl.pdb, an install target is created so as
it gets copied to where mod_perl.so goes. I've also added a
needed -debug flag to the linker, in cases where the present
s/-release/-debug/ doesn't work (which happens for me).
I've also included in this an install target for the
generated mod_perl.lib, for use with 3rd party modules
+1 on the concept, with a few minor comments below. Can you please resubmit it as an attachment, so we can test the patch. the inlined patch loses tabs in the make sections.
[...](as suggested in the modperl_libs_MSWin32 sub). ================================================================== Index: Build.pm
@@ -1058,8 +1060,11 @@
sub dynamic_link_MSWin32 {
my $self = shift;
my $defs = $self->export_files_MSWin32;
+ my $symbols = $self->modperl_symbols_MSWin32;
return $self->dynamic_link_header_default .
- "\t$defs" . ' -out:$@';
+ "\t$defs" .
+ ($symbols ? ' \\' . "\n\t-pdb:$symbols" : '') .
+ ' -out:$@';
probably will read better if all concats will be aligned:
return $self->dynamic_link_header_default . - "\t$defs" . ' -out:$@'; + "\t$defs" . + ($symbols ? ' \\' . "\n\t-pdb:$symbols" : '') . + ' -out:$@';
+sub otherldflags_MSWin32 {
+ my $self = shift;
+ my $flags = $self->otherldflags_default;
+ $flags .= " -pdb:\$(INST_ARCHAUTODIR)\\\$(BASEEXT).pdb" if $self->{MP_DEBUG};
+ $flags;
}
won't this work?
$flags .= ' -pdb:$(INST_ARCHAUTODIR)\$(BASEEXT).pdb' if $self->{MP_DEBUG};
/me is trying to avoid unnecessary backslashism.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
