[Fri Jul 18 05:56:12 2003] [error] 16872: ModPerl::Registry: 304:Unknown error 304 at [module name and line number].
I traced this to an oversight in the file modperl_filter.c. It did not consider the 304 to be a successful return. I made the following modification, and now all's well:
--- orig/mod_perl-1.99_09/src/modules/perl/modperl_filter.c 2003-04-18 01:34:12.000000000 -0400 +++ src/modules/perl/modperl_filter.c 2003-07-18 11:19:07.000000000 -0400 @@ -114,5 +114,5 @@ return APR_SUCCESS; /* XXX: HTTP_MOVED_TEMPORARILY ? */ } - else if (status != OK) { + else if (status != OK && status != HTTP_NOT_MODIFIED) { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, r->server, "%s did not send an HTTP header",
This is not right, since status doesn't really contain HTTP status, but the execution status (OK or error), with HTTP_MOVED_TEMPORARILY being just a hack.
[...]Can you please post a simple test and the relevant configuration? You can even send a new test for our ModPerl-Registry test suite.
Unfortunately, I don't have the time to post a formal test case, but I can quite easily give you the test Registry script to base one on:
Dan, unfortunately I can't reproduce this problem (I think I did some time ago, but not any longer). I've added a formal test to the mod_perl test suite which works for me. Can you please get the latest mod_perl 2.0 cvs
http://perl.apache.org/download/source.html#Development_mod_perl_2_0_Source_Distributionand see if it works for you. If it doesn't try to break it.
After you complete the normal build and test, do:
cd ModPerl-Registry t/TEST -v 304
the relevant files are t/304.t and t/cgi-bin/304.pl
Thanks a lot.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
