Steve Hay wrote:
Hi,

After running the test suite with mp1.28 on Windows I find that I have a temporary file left behind in my temp dir (in my case, C:\Temp).

This happens because the filehandle is left open. The attached patch closes it, and the file gets deleted automatically later.

I suppose we can/should do that, but isn't it a responsibility of CGI.pm to do that?


      -private_tempfiles
           CGI.pm can process uploaded file. Ordinarily it spools the uploaded
           file to a temporary directory, then deletes the file when done.
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I remember this was a bug in the older CGI.pm versions, which was fixed long time ago. I can't reproduce it with CGI 2.97.

------------------------------------------------------------------------

diff -ruN mod_perl-1.28.orig/t/net/perl/cgi.pl.PL mod_perl-1.28/t/net/perl/cgi.pl.PL
--- mod_perl-1.28.orig/t/net/perl/cgi.pl.PL     2003-06-06 12:31:12.000000000 +0100
+++ mod_perl-1.28/t/net/perl/cgi.pl.PL  2003-08-18 16:46:57.000000000 +0100
@@ -19,4 +19,5 @@
     local $/;
     $content = <$httpupload>;
     $r->print( "ok $content\n" );
+    close $httpupload;
 }



------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--


__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to