Stas Bekman wrote:
I have noticed that mp2 API doesn't have APIs to retrieve vhost's server_root and document_root. I've talked to the guys at #apr, and they suggest to add new C APIs: ap_server_root(s) and ap_server_document_root(s)
the latter is cumbersome as there is already ap_document_root(r), they think to have ap_document_root(r, s) in 2.1.
So what API should we have in mp2, stick to ap_server_document_root(s), to be identical with httpd-2.0, or should we fix that for our users to make it intuitive (i.e. let document_root accept $s as well). I propose:
$r->document_root; # we have it already $s->document_root; # new: $s->server_root; # new:
this option makes more sense and is more mod_perlish. we just need to ensure that $r->document_root doesn't corrupt $s->document_root (which is probably not up to us). that's one way to bring a frontpage server to a halt :)
After posting this I wanted to write a C accessor, but have found out that httpd's docs advise not to use ap_document_root at all, as it may cause problems. I've posted a question to httpd-dev, but have received no answers so far.
As for $s->server_root, it should probably be $s->server_path, since that corresponds to the ServerPath directive and the server_rec struct's element.
Unrelated we can have $s->server_root, poiting at the main server's root. Or we can have $s->server_path do that.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
