this is a pretty big deal, as mod_perl tests have always run against a single available server. are we sure that this isn't going to be problematic on some platforms (namely win32, as usual :)? though I guess from the docs MaxClients is meaningless to that mpm.
Not really, all tests designed to hit the same perl interpreter are using the special API (grep for 'same_interp'). If you know of tests that must be fixed, let me know.
no, I don't. it's just that we all know that running in single-server mode is way different than running against multiple servers. I'm surprised you made the change so swiftly.
remember what bugs you uncovered when you started running the tests in random order? this is the same kind of thing - introducing a new variable that may result in some new test failures for somebody.
What's your point? We shouldn't introduce new tests, if they require more than one server?
If the tests that needed to be run against the same server were written without ensuring that, those a broken test. Someone will discover that and we will fix that.
Moreover, just like you sometimes miss problems when you run in a non-single mode, you may miss problems when you run a single mode. I have seen both.
This change is needed for more upcoming tests. I'm planning to add SSL tests and proxying over ssl, which will require more than one server instance.
it also probably warrants something in Changes.
not really, IMHO, this changes nothing in the mod_perl functionality. Changes file is there to tell the important changes significant to users, not internal changes and tweaks that don't affect them.
ok. but don't say I didn't warn you when they come knocking :)
I'm not worried. Blowing up the Changes file with irrelevant information makes it not very useful to users. Those who want the low-level details can use cvs to get the commit logs.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
