On Tue, 2 Sep 2003, Stas Bekman wrote: > Randy Kobes wrote: [ .. ] > > The following seems to fix the problems both with > > t/modules/cgi.t and t/modules/cgiupload.t: > > ============================================================ > > Index: src/modules/perl/modperl_io_apache.c > > =================================================================== > > RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_io_apache.c,v > > retrieving revision 1.3 > > diff -u -r1.3 modperl_io_apache.c > > --- src/modules/perl/modperl_io_apache.c 21 Aug 2003 01:37:20 -0000 1.3 > > +++ src/modules/perl/modperl_io_apache.c 2 Sep 2003 01:37:55 -0000 > > @@ -187,7 +187,7 @@ > > sizeof(PerlIO_funcs), > > "Apache", > > sizeof(PerlIOApache), > > - PERLIO_K_MULTIARG, > > + PERLIO_K_MULTIARG | PERLIO_K_RAW, > > PerlIOApache_pushed, > > PerlIOApache_popped, > > PerlIOApache_open, > > =============================================================== > > I haven't tested this on Unix, though. > > Excellent catch, it works on linux (since unix has no need for binmode). [ .. ] > Please commit. > > Also we probably need to add it to > xs/APR/PerlIO/apr_perlio.c (again | with > PERLIO_K_MULTIARG), can you think of a test to add to > t/response/TestAPR/perlio.t that will break it in a > similar way, before we fix it?
OK, thanks - I've done that. I'll work on a test that illustrates the problem for APR::PerlIO, and submit that soon. -- best regards, randy --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
