Carl Brewer wrote:





-------------8<---------- Start Bug Report ------------8<---------- 1. Problem Description:

current CVS barfs at make time :

modperl_filter.c: In function `modperl_run_filter_init':
modperl_filter.c:362: parse error before `extern'
modperl_filter.c: In function `modperl_run_filter':
modperl_filter.c:434: parse error before `extern'
*** Error code 1

diff -u -r1.66 modperl_filter.c --- src/modules/perl/modperl_filter.c 20 Aug 2003 23:10:09 -0000 1.66 +++ src/modules/perl/modperl_filter.c 15 Sep 2003 05:31:20 -0000 @@ -359,6 +359,10 @@

SvREFCNT_dec((SV*)args);

+#ifdef USE_ITHREADS
+    MP_dINTERP_PUTBACK(interp);
+#endif
+
     MP_TRACE_f(MP_FUNC, MP_FILTER_NAME_FORMAT
                "return: %d\n", handler->name, status);

@@ -429,6 +433,9 @@
         MP_FAILURE_CROAK(modperl_output_filter_flush(filter));
     }

+#ifdef USE_ITHREADS
+    MP_dINTERP_PUTBACK(interp);
+#endif
     MP_TRACE_f(MP_FUNC, MP_FILTER_NAME_FORMAT
                "return: %d\n", handler->name, status);

But better just comment them out for now. I see some other problems that somehow caused by this change, discovered by t/SMOKE. I'm looking at it.

Index: src/modules/perl/modperl_filter.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.66
diff -u -r1.66 modperl_filter.c
--- src/modules/perl/modperl_filter.c   20 Aug 2003 23:10:09 -0000      1.66
+++ src/modules/perl/modperl_filter.c   15 Sep 2003 05:29:38 -0000
@@ -359,6 +359,8 @@

SvREFCNT_dec((SV*)args);

+//    MP_dINTERP_PUTBACK(interp);
+
     MP_TRACE_f(MP_FUNC, MP_FILTER_NAME_FORMAT
                "return: %d\n", handler->name, status);

@@ -428,6 +430,8 @@
     else {
         MP_FAILURE_CROAK(modperl_output_filter_flush(filter));
     }
+
+//    MP_dINTERP_PUTBACK(interp);

     MP_TRACE_f(MP_FUNC, MP_FILTER_NAME_FORMAT
                "return: %d\n", handler->name, status);



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to