Stas Bekman wrote:
[EMAIL PROTECTED] wrote:
geoff 2003/10/14 10:34:06
Modified: . Changes Log: add PerlMapToStorageHandler remove last comment - stringified returns worked in last release so nothing has changed between releases
[...]
-callbacks returning values which aren't integers or strings (which are -to be coerced into integers) are now interpreted as errors. [Geoffrey -Young]
what do you mean not changed? previously they were generating warnings at best and nothing at all if -w was off, now it's a fatal error. IMHO, that's an important change for users to know.
whoops. sorry, I misread that. I thought it was talking about the coersion, which happened before.
nevertheless, the comment is kinda confusing - it seems to be joining two separate issues that we jumbled around ourselves :)
the first issue was that you fixed calls to MP::Util::exit() to not throw warnings - they still return OK (as before).
likewise, strings as integers ('0', 'foo', and 'foo9bar') work as the did before - it was still POPi in 1.99_10.
thus the real difference is for when undef isn't PL_sv_undef for some reason - that's what is getting 500 where it wasn't before. and it is going to be pretty difficult for end-users to do that intentionally, by which I mean if they wanted to experience first hand what that meant, they would have to know to end a routine with an XS function that trips up it's return value someplace ($s->log->info) and not just something like print(). even returning undef doesn't force 500 (as I just tested and will add to the suite).
I'm really not trying to be critical or over-zealous here - it just got me thinking about the real change beneath it all. as I see it, the functional change is kinda rare and awfully difficult to describe. what has changed, though, is our expectation from handlers.
so, I think we can boil all that down into two brief comments in Changes:
callbacks are now expected to return a meaningful value (OK) or exit via an official API (exit, die, etc).
removed undefined warnings for ModPerl::Util::exit
I think that will make the most sense to users. if Changes is supposed to be able to help them understand the difference between versions, that is. you could even leave the second one out, I'd think.
--Geoff
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
