On Wed, 15 Oct 2003, Steve Hay wrote:
Attached is a patch to stop this warning being printed every time I run "perl Makefile.PL ...":
Use of uninitialized value in concatenation (.) or string at lib/ModPerl/BuildOptions.pm line 107, <DATA> line 20.
- Steve
===================================================================== --- BuildOptions.pm.orig 2003-10-07 19:28:38.000000000 +0100 +++ BuildOptions.pm 2003-10-15 11:43:18.272019200 +0100 @@ -105,7 +105,7 @@
my $fh; my @files = map { $_ . 'makepl_args.mod_perl2' } - qw(./ ../ ./. ../.), "$ENV{HOME}/.";
why not check for exists $ENV{HOME}?
+ qw(./ ../ ./. ../.), (Apache::Build::WIN32() ? () : "$ENV{HOME}/."); unshift @files, $self->{MP_OPTIONS_FILE} if $self->{MP_OPTIONS_FILE};
for my $file (@files) { @@ -164,6 +164,8 @@
sub table { $Table ||= parse_table(\*DATA); + close DATA; + return $Table; }
close DATA? but we have never opened it. What if this handler is reused second time under the same perl, it'll find the DATA fh closed? are you sure that this is the right solution?
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
