This only leaves the problem of it occasionally picking up the "wrong" PID file:-
Anyway, I thought I'd add some code in try_exit_opts() to remove the PID file, but it still didn't always work. I added more code to print out the PID file that it was deleting and found that sometimes it is the "wrong" one. Here's what I've added in try_exit_opts(), just before the "exit_perl $ok" at the end of that function:
my $t_logs = $self->{test_config}->{vars}->{t_logs}; my $pid_file = catfile $t_logs, "httpd.pid"; open my $fh, ">C:\\Temp\\debug.txt"; print $fh "Removing PID file '$pid_file' ...\n"; close $fh; unlink $pid_file if -e $pid_file;
It seems that whether or not this works depends on exactly when I happen to press Ctrl+C. One time it said
Removing PID file 'C:\Temp\modperl-2.0\t\logs\httpd.pid' ...
and sure enough the PID file was gone, but another time it said
Removing PID file 'C:\Temp\modperl-2.0\docs\devel\core_explained\CVS\t\logs\httpd.pid' ...
and, of course, the main PID file 'C:\Temp\modperl-2.0\t\logs\httpd.pid' was left behind.
Now I haven't got a clue what's going on. Any ideas?
File::Find looks for core dumps after each execution. Perhaps you Ctrl-C'ed it when it was inside docs\devel\core_explained?
Maybe, but...
Perhaps we need to expand vars like $self->{test_config}->{vars}->{t_logs} to a full path, in which case it won't be an issue?
... as you see from the output above the (wrong) PID file that it deleted is fully-pathed anyway!
but that's a wrong full path. docs\devel\core_explained is not the top_dir, meaning that somewhere we have a glitch and not using a fullpath.
Also this core files scan, is it relevant at all to WIN32? When you get a coredump, do you get a core file?
No, there's no core files on Win32. "Dr Watson's log files" would be the closest thing I suppose, but you don't really want to go there. Perhaps if we skip the coredump scan on Win32 then the problem of the "wrong" PID file being picked up would go away?
I suggest we first fix the problem of the wrong path, since it may bite us elsewhere later.
Next please submit a patch to skip core_scan (there are two versions in TestRun), which will make SMOKE much faster on win32.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
