Re: Useless use of a constant in void context at Makefile.PL line 467

[Carl Brewer]

Stas Bekman wrote:

Carl Brewer wrote:

Stas Bekman wrote:


So the offending line is:

 $string .= Apache::Test::install::nuke_Apache__test_target()
         if APACHE_TEST_INSTALL();
You lost the actual constant that it was complaining about ;) I 
should have looked closer.

Any change if you replace it with:

if (APACHE_TEST_INSTALL()) {
   $string .= Apache::Test::install::nuke_Apache__test_target();
}


Nope, same error.


OK, what happens if you replace that line with:

print APACHE_TEST_INSTALL ? "APACHE_TEST_INSTALL" : "NOT 
APACHE_TEST_INSTALL";
$string .= Apache::Test::install::nuke_Apache__test_target();

does it complain about the print line, or the $string one?
It's complainign abuot the test line :

    if (APACHE_TEST_INSTALL()) {


Also what happens if you change

BEGIN {
    use constant APACHE_TEST_INSTALL => -e 'Apache-Test';
    use lib './Apache-Test';
    require 'install-pl' if APACHE_TEST_INSTALL;
}
to:

BEGIN {
    use constant APACHE_TEST_INSTALL => -e 'Apache-Test';
I think this is the bit that isn't working.  The constant isn't being
set, so the -e 'Apache-Test' test is failing.
This would be consistant with there being no such directory if you
do a straight CVS checkout, rather than untar'ing a distribution
and then using CVS updates.  Is this something we need to fix in
the CVS tree, or something?



    use lib './Apache-Test';
    if (APACHE_TEST_INSTALL) {
      warn "loading install-pl';
      require 'install-pl';
    }
}
does it print "loading install-pl"?
no

Finally try replacing:

 require 'install-pl';
with
 require './install-pl';
Done, no change

Carl



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]