On Tue, 2003-11-11 at 17:04, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > Until now, code executing within <Perl > sections was not 'tweaked' to > > match the filename/lineno of the httpd configuration file it was in. > > > > So, for example, error reporting would appear to be coming from obscure > > eval contexts. > > > > Following patch restores the same behaviour than in mp1. > > +1, with a single style fix below
I lack in style ;-p Style fixed and change applied! > > Index: Changes > > =================================================================== > > RCS file: /home/cvs/modperl-2.0/Changes,v > > retrieving revision 1.249 > > diff -u -I$Id: -r1.249 Changes > > --- Changes 10 Nov 2003 21:11:53 -0000 1.249 > > +++ Changes 11 Nov 2003 20:24:24 -0000 > > @@ -14,6 +14,9 @@ > > > > =item 1.99_11 - November 10, 2003 > > > > +<Perl> sections now proprely set filename and line number information, > > +making error messages report the correct location. [Philippe M. Chiasson] > > You probably didn't cvs update your Changes ;) > > > Index: src/modules/perl/modperl_cmd.c > > =================================================================== > [...] > > + line_header = apr_psprintf(p, "\n#line %d %s\n", > > parms->directive->line_num, parms->directive->filename); > > This line needs to be wrapped. > > > __________________________________________________________________ > Stas Bekman JAm_pH ------> Just Another mod_perl Hacker > http://stason.org/ mod_perl Guide ---> http://perl.apache.org > mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com > http://modperlbook.org http://apache.org http://ticketmaster.com -- -------------------------------------------------------------------------------- Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B) http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5 Q: It is impossible to make anything foolproof because fools are so ingenious. perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
signature.asc
Description: This is a digitally signed message part
