[...]After making the small changes we discussed, here is a simpler version of the original <Perl> namespace patch, without exposing it thru ModPerl::Util and a few style tweaks as per stas's recommendations.
Looks great! + a few indent comments ;)
Index: src/modules/perl/modperl_util.c^^
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_util.c,v
retrieving revision 1.58
diff -u -I$Id: -r1.58 modperl_util.c
--- src/modules/perl/modperl_util.c 25 Nov 2003 20:31:29 -0000 1.58
+++ src/modules/perl/modperl_util.c 15 Dec 2003 23:13:28 -0000
@@ -769,3 +769,53 @@
} }
#endif
+
+#define MP_VALID_PKG_CHAR(c) (isalnum(c) ||(c) == '_')
+#define MP_VALID_PATH_DELIM(c) ((c) == '/' || (c) =='\\')^^
+ /* Then figure out how big the package name will be like */
+ for(f = file; *f; f++) {
[...]Index: t/conf/extra.last.conf.in ===================================================================
+push @Apache::ReadConfig::Alias, + ['/perl_sections_readconfig', '@DocumentRoot@'];
+$Apache::ReadConfig::Location{'/perl_sections_readconfig'} = {
+ 'PerlInitHandler' => 'ModPerl::Test::add_config',
+ 'AuthType' => 'Basic',
+ 'AuthName' => 'PerlSection',
+ 'PerlAuthenHandler' => 'TestHooks::authen',
+ };
^^^^^ indent 4, and align => keys if you feel like ;)
[...]Index: t/response/TestDirective/perldo.pm ===================================================================
+ {
+ no strict 'refs';
+ %Location = %{$TestDirective::perl::PACKAGE . '::Location'};
+ }
indent
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
