Stas Bekman wrote: > Here is the implementation of ($r|$s)->is_hook_enabled($hook_name).
coolio. > > I'm not sure about the name of this method though. If it tests > PerlOptions, may be it should be called just that: > is_perl_option_enabled()? the _hook_ part comes from: > http://perl.apache.org/docs/2.0/user/config/config.html#C_Perl_Handler_ > but really works for any of: > http://perl.apache.org/docs/2.0/user/config/config.html#C_PerlOptions_ since it's not only hooks, I'd prefer is_perl_option_enabled, or even just is_option_enabled (as everything is PerlSomething :) > +use Apache::Const -compile => qw(OK DECLINED DONE); you only use OK :) > +my @srv_plus = qw(ChildInit ChildExit); what about some tests for things that are enabled by default but not in your config, like Fixup? also, does the method merge settings for you? that is, does $r->is_hook_enabled show per-server settings that would be inherited by the request? you're tests don't show it if it does, and it would be a pain to need to check both if it doesn't. btw, this is much better than the old mod_perl::import(). nice. --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
