Geoffrey Young wrote:
hi all

joe schaefer suggested on modperl@ that having access to apr_brigade_flatten
might be of use.  at least in the context of Apache::Request::Upload you
could use

my $upload_data = $req->upload('file')->bb->flatten;

to essentially slurp up the file without iterating the brigade manually.

I'm not sure about how this would fit into filters, since I guess there are
multiple brigades, but I'm not sure.

anyway, any arguments against opening it up? (with tests, of course :)

I certainly have no objections to opening up the entire APR API if someone needs it. And most of the APR::(Brigade|Bucket) API is needed in filters.


I've already replied to Joe, that I think apreq2 shouldn't expose the bucket brigade interface or at least have a simple alternative method which will do all the work behind the scenes (which also removes the immediate need for flatten, since there is the C API for that).

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to