geoff 2004/01/19 11:02:41
Modified: lib/Apache compat.pm
t/response/TestAPI server_util.pm
t/response/TestCompat apache.pm
xs/maps apache_functions.map
Log:
Apache::exists_config_define is now Apache::Server::exists_config_define
Revision Changes Path
1.100 +1 -1 modperl-2.0/lib/Apache/compat.pm
Index: compat.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
retrieving revision 1.99
retrieving revision 1.100
diff -u -r1.99 -r1.100
--- compat.pm 19 Jan 2004 18:47:32 -0000 1.99
+++ compat.pm 19 Jan 2004 19:02:41 -0000 1.100
@@ -268,7 +268,7 @@
sub define {
shift if @_ == 2;
- exists_config_define(@_);
+ Apache::Server::exists_config_define(@_);
Hmm, I now see why Apache::Server is not quite suitable for exists_config_define. As I've suggested in one of the replies re: current_callback. exists_config_define(@_) is not a server instance "attribute", but Apache's application "attribute". So if when we write Apache::Server we are talking about $s, it doesn't fit into
Apache::Server::exists_config_define(@_);
I suppose Apache:: is for all those methods/functions that don't fit into Apache::Server, i.e. work before any servers are started.
I wish it had hit me earlier, and not after geoff's nice commits.
May be we should take this further and make Apache::Server what Apache:: is used to be: i.e., just the httpd accessors. And create Apache::ServerRec similar to Apache::RequestRec which will give the access to $s?
Same with ConnRec?
Obviously we need to wait a bit with changing everything and sleep on it for some time.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
