Steve Hay wrote:
Stas Bekman wrote:


Steve, Randy, can you please try with this patch. This is against the conf file with:

<VirtualHost _default_:8542>
PerlOptions +Parent
<Perl>
  1;
</Perl>
</Virtualhost>

The Good News: The patch below fixes *both* of the short conf files that we've been playing with. Running "apache.exe -t ..." was previously enough to produce the crash; now I can even start the server up (i.e. without the "-t" option) without error.

Great. So it was a wrong context issue after all.


Could you try remove the last chunk of this patch. i.e. remove the part that 'restore the original perl context; and see if it still works.

The Bad News: The vhost test that originally didn't work way back at the start of this thread (excuse the pun) still doesn't work.

heh, I forgot what was the original one ;) can't you pin-point which part of that patch causes the problem? I assume the problem is the same, right?


I'll try the other patch that you e-mailed separately as well and see if that helps...

probably won't change anything, but give it a try.


Index: src/modules/perl/modperl_cmd.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_cmd.c,v
retrieving revision 1.52
diff -u -r1.52 modperl_cmd.c
--- src/modules/perl/modperl_cmd.c      19 Dec 2003 01:17:31 -0000      1.52
+++ src/modules/perl/modperl_cmd.c      21 Jan 2004 03:35:36 -0000
@@ -373,6 +373,7 @@
#ifdef USE_ITHREADS
    MP_dSCFG(s);
    pTHX;
+    PerlInterpreter *orig_perl;
#endif

    if (!(arg && *arg)) {
@@ -388,7 +389,9 @@

#ifdef USE_ITHREADS
    /* XXX: .htaccess support cannot use this perl with threaded MPMs */
+    orig_perl = PERL_GET_CONTEXT;
    aTHX = scfg->mip->parent->perl;
+    PERL_SET_CONTEXT(aTHX);
#endif

    /* data will be set by a <Perl> section */
@@ -479,6 +482,11 @@
        }
    }

+#ifdef USE_ITHREADS
+    /* restore the original perl context */
+    PERL_SET_CONTEXT(orig_perl);
+#endif
+
    return NULL;
}




__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to