On Thu, 2004-02-12 at 18:46 -0500, Geoffrey Young wrote:
Oh, well, that's the price to pay when you are not riding the "bleeding" edge ;-)
:)
I guess we need to decide what to do about warnings like these that aren't caught by older versions of gcc - either the remaining two of us need to upgrade or, well, I don't know what.
Well, for now, I don't mind being the gcc -Wall police and expose & fix problems as I experience them. No urgent need to force a forward upgrade for anybody.
ok, cool. the first error looks pretty bogus to me, though - I guess it's the split if-blocks that are giving it trouble (or it's too late in the evening for me :)
Yes, seems the compiler is tripping there (probably the #ifdefs) and shouldn't be a problem, really.
Just doing modperl_interp_t *interp = NULL; should shut it up (read, 'please geoff')
The compiler is correct about this warning. Since MpDirSETUP_ENV(dcfg) may return false on the first call, but true on the second.
I think another solution, is what I've proposed before - drop MpDirSETUP_ENV conditional from select/unselect code and leave it only around modperl_env_request_populate(aTHX_ r);
It shouldn't have a big overhead, because select/unselect happens anyway later on in the callback, which is does two if calls and returns:
...
if (rcfg && rcfg->interp) {
/* if scope is per-handler and something selected an interpreter
* before modperl_callback_run_handlers() and is still holding it,
* e.g. modperl_response_handler_cgi(), that interpreter will
* be here
*/
MP_TRACE_i(MP_FUNC,
"found interp 0x%lx in request config\n",
(unsigned long)rcfg->interp);
return rcfg->interp;
}Philippe's solution is fine too.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
