On Fri, 2004-02-20 at 16:54 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > This is a followup on my previous patch to attempt and solve the > > problems people are having with Apache-Test on boxes with IPv6 and no > > support for ipv4-mapped addresses in httpd. > > > > Instead of hard-coding 127.0.0.1 in the listen directive, this patch > > uses the servername instead. > > > > The original problem was with statements such as: > > > > Listen 80 > > > > That on IPv6 with no IPv4-mapped address would end up listening strictly > > on the IPv6 loopback address (::1) > > > > What seems to me like a superior solution is to use the servername > > instead. That way, if a user has trouble because localhost defaults > > to ::1 on his/her setup, passing -servername to ./t/TEST will fix the > > problem. > > > > For example > > > > ./t/TEST -servername some.name.for.an.ipv4.address.of.this.box > > > > And then, of course, once LWP & Perl become IPv6 friendly, the tests > > will be successfull even if localhost on the box points to ::1. > > Sounds very good to me. I hope we don't miss some special cases we haven't > thought of.
We'll have to see about that. I am indeed a tiny bit curious about the resolving logic I ended up removing. I searched all over perl-framework and I couldn't find a single place it was being used. > > Only annoying side-effect is that this patch disables name-lookups on > > the servername (I couldn't find a reason why it was doing it in the > > first place anyhos). > > I wonder too. I guess there was a reason for doing that. Unfortunately it > wasn't documented. Well, I imagine that if this change does cause trouble, and we have to re-add that logic, at least we'll know why it was there in the first place. > > mod_perl 2.0 tests 100% fine with it, and so does perl-framework (no > > new errors). > > > > Thoughts ? > > +1 to commit. Done. > We can always revert things back if we find that there is a > problem with that approach. put it in and I'll post an A-T release candidate > shortly afterwards. Release away! > > __________________________________________________________________ > Stas Bekman JAm_pH ------> Just Another mod_perl Hacker > http://stason.org/ mod_perl Guide ---> http://perl.apache.org > mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com > http://modperlbook.org http://apache.org http://ticketmaster.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] >
signature.asc
Description: This is a digitally signed message part
