> This is exactly what I was talking about. Making it configurable at > startup time.
:) actually, once I got it figured out, it's probably possible to support per-dir hook ordering as well, but I don't think it's valuable enough to warrant additonal effort. but it's possible ;) > I don't know about having one directive per handler, why > not something like : > > PerlHookOrder trans last > > I don't mind the multiples directive much, and it's not like we are > facing new directives all the time, but it just feels cleaner to me that > way. yeah, I was debating on that too. I suppose it could be like that, or maybe PerlHookOrder PerlTransHandler Last in either case, it would be fewer hooks but a larger validation routine. >> 2 - on a parallel with this specific feature, I noticed that mod_perl >>hooks PerlOptions +GlobalRequest logic in post-read-request and >>header-parser phases, via RUN_FIRST. since we moved user-defined >>PerlInitHandler logic to RUN_REALLY_FIRST, its possible that user-defined >>Perl handlers will run _before_ mod_perl gets the chance to insert its >>global logic. I'm not sure if this is a bad thing, but it sounds bad. > > > Sure _sounds_ bad AFAIK yeah, that's why I bumped the internal logic really, really first - a gut feeling. > Gota love those first, really first, our really first, our really really > first, etc ;-) :) > > All in all, this looks like good works, see few comments below. cool, thanks. > Does this ordering information need to be in the server-configuration > request since it's really a global? yeah, stas pointed that out too. I'll fix it on the next pass. thanks. --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
