On Sat, 2004-02-28 at 14:46, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > Improvements to my previous patch:
> > 
> > - Small cleanups as suggested.
> > - Documented
> 
> [...]
> > Index: lib/Apache/PerlSections/Dump.pm
> [...]
> > +#Process all saved packages
> > +sub package     { return shift->saved }
> > +
> > +#We don't want to save anything
> > +sub save        { return }
> > +
> > +#We don't want to post any config to apache, we are dumping
> > +sub post_config { return }
> 
> can you please separate # and text with a space? thanks.
> 
> # We don't want ...

Sure thing.

> otherwise +1

Thanks for the extra eyes ;-)

Committed!

> __________________________________________________________________
> Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/     mod_perl Guide ---> http://perl.apache.org
> mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org   http://ticketmaster.com
-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to