Joe Orton wrote:
[...]
If you want to be conservative, just stick with EXTRA_CPPFLAGS; this
should be sufficient to make sure apr.h can be safely included.  The
problem is if you use EXTRA_CFLAGS you need NOTEST_CPPFLAGS normally,
since the latter prevents some GCC warnings which the former will
induce.

Thanks, Joe. I'm now testing with this conservative idea. Do you have an access to Solaris, to give it a try once I polish it on linux?


[...]

Finally the ccopts function could do with doing some normalization of
the union of the perl/Apache CFLAGS now since "-g -O2 -D_GNU_SOURCE" etc
will be used twice otherwise.

Sure, I'll do that. But is there any harm in those duplicates?


Probably not, no. It's just a cosmetic thing really.

It's going to be a tricky thing to do, besides the obvious 1:1 dups. How should we deal with cases like:
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Werror


-Wall added by mod_perl, the rest are by apache. I think when -Wall is in place, the rest of -W can be removed, but may be there are extra -W flags which aren't included by -Wall?

or cases when we have:

-O0 and -O2

Should we pick -O2 or -O0? What gcc does when it sees both options?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to