Stas Bekman wrote:
> todays Joe patch triggered my interest to further test the socket
> set/get options, just to discover that opt_get doesn't work at all. So I
> made it working and made both APIs perlish, croacking in case of the
> failure instead of returning status. Sounds good?
I like the idea of returning the value instead of the status - that's
something that we should probably enforce more consistently than we do.
I'm not entirely convinced that croak is a good thing. consider that perl's
native getsockopt() and setsockopt() both return undef on error rather than die.
and I know we've discussed this before, but I really don't like the idea of
croaking at request time - for configuration things it's ok, but the vast
majority of file IO and other operations in perl proper don't die: open,
read, most of the IO:: stuff, etc. in other words, people expect to check
return values for these things instead of needing eval{} so we're throwing
them a curve every time we croak instead.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
