Boris Zentner wrote:
Hi Stas,

Am Montag, 19. April 2004 23:38 schrieb Stas Bekman:

Boris Zentner wrote:

1. Problem Description:

ht_time formats the time with the locale info, that was present at the
start of the server. Is this desired?

I think yes.



And this breaks the mod_perl tests for apache/util.

You didn't show what's failing. That test already does regex mathing instead of comparing the dates. I'm not sure what's wrong, I've tried with en_GB and it worked just fine:



Ahh sorry, it was so clear for me. That I have it not written explicite.
For german we have


Mo, 19 Apr 2004 23:18:09 GMT

and the test is about /^\w{3}, \d\d \w{3} \d{4} \d\d:\d\d:\d\d/

this does not match 'Mo' you can do /^\w{1,3}, \d\d \w{1,3} \d{4} \d\d:\d\d:\d\d/

or

/^\w+, \d\d \w+ \d{4} \d\d:\d\d:\d\d/

Ouch, can you please submit a patch that works for you? \w+ is good, as I'm afraid we may have similar issues with other languges who may have 4 chars or else. Thanks.


Ideally we should pick up the locale setting, generate a real string using it and strftime and do the comparison. The problem is that we can't control the time that Apache sees, so we can always have a mismatch of 1 and more secs, which may completely change the string if it happens at 23:59:59.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to