Remove, no, but something like this will do:
# if no build mode is specified default to DSO unless ($build->{MP_USE_DSO} or $build->{MP_USE_STATIC}) { $build->{MP_USE_DSO} = 1; }
Yes, something like that. Unless you can think of something that would break with this change, make it so ;-)
I will leave that to your patch. You will need to add more logic to verify that someone doesn't try to use USE_DSO and AP_CONFIG... args etc.
but otherwise, yes, I prefer to see $build->should_link_static used there.
That means renaming to sub should_link_static { shift->{MP_USE_STATIC} ? 1 : 0 }
and then use it both in the test and in the Makefile.PL.
To start with. That will allow us to use more complex logic and it'll be all placed in location.
I'll resubmit a slighlity modified static build patch including that shortly.
Cool __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
