Stas Bekman wrote:
Can you take a look at apr_password_validate and see why it doesn't validate on windows?
Doh! -- it contains this:
#if defined(WIN32) || defined(BEOS) || defined(NETWARE) apr_cpystrn(sample, passwd, sizeof(sample) - 1); #elif...
Hmm, what's the point of having APR function which doesn't work crossplatform? Do we want to support it at all?
so the below patch makes it pass on Win32.
More like hiding the problem, IMHO. Making a test pass is easy, the question is whether it actually tests something.
Is mp2 supported on BeOS / NetWare?
I have no clue. In theory it should run on all platforms Apache and Perl are supported, but I don't remember anybody reporting any successes or failures on those platforms.
Index: t/response/TestAPR/util.pm =================================================================== RCS file: /home/cvspublic/modperl-2.0/t/response/TestAPR/util.pm,v retrieving revision 1.8 diff -u -r1.8 util.pm --- t/response/TestAPR/util.pm 22 May 2004 21:47:32 -0000 1.8 +++ t/response/TestAPR/util.pm 25 May 2004 10:19:32 -0000 @@ -23,7 +23,7 @@ ok ! APR::Util::password_validate("one", "two");
my $clear = "pass1"; - my $hash = "1fWDc9QWYCWrQ"; + my $hash = $^O =~ /MSWin32/ ? $clear : "1fWDc9QWYCWrQ"; ok APR::Util::password_validate($clear, $hash);
That's comparing clear text to clear text, isn't it?
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
