Stas Bekman wrote:
Philippe M. Chiasson wrote: [...]
Here is a revised patch that still works for me.
(http://svn.ectoplasm.org/gozer/opt/src/apache.org/mod_perl/2.0/patches/static-build.patch)
Looks good
Thanks, the changes were mostly cosmetic, but I think your suggestions made it clearer.
Index: Apache-Test/lib/Apache/TestConfig.pm ===================================================================
[...]
# untaint some %ENV fields local @ENV{ qw(PATH IFS CDPATH ENV BASH_ENV) };
+ $ENV{PATH} = '/bin:/usr/bin:/usr/local/bin'; my $handle = Symbol::gensym(); open $handle, "$cmd|" or die "$cmd failed: $!";
What do you need that for and why the hardcoded paths?
That's an artefact from my builds that I could remove, I guess. It's because if you run a static build and tests against a non-installed httpd build, the actual httpd binary is a smart libtool shell script plucking things from .libs/ and such, right? And it uses plenty of ls, sed, grep and friends. When those things are not in the path anymore, the httpd binary (shell script) will not work at all.
Of course, I don't think there are a lot of folks out there that would run tests that way without installing httpd, but I do.
-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
