Randy Kobes wrote: > Further to the splitting off of APR::* from mod_perl.so, the > following diff moves a couple of functions from > src/modules/perl/modperl_util.c to > src/modules/perl/modperl_common_util.c, so that APR::OS and > APR::URI would be usable outside of mod_perl.so: > ========================================================= > ? s.txt > Index: modperl_common_util.c > =================================================================== > RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_common_util.c,v > retrieving revision 1.1 > diff -u -r1.1 modperl_common_util.c > --- modperl_common_util.c 16 Jun 2004 03:55:47 -0000 1.1 > +++ modperl_common_util.c 21 Jun 2004 05:00:55 -0000 > @@ -20,6 +20,7 @@ > * needed in order to keep the libraries used outside mod_perl > * small */ > > +#include "mod_perl.h"
that doesn't sound right. I think mod_perl.h shouldn't be used by common or APR-specific parts, since it creates dependecies on modperl_*. It may work now but may break in the future. If you look in that header file, it loads the component header files.
#include "modperl_apache_includes.h" #include "modperl_common_includes.h" #include "modperl_apache_compat.h"
the rest is good.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
