I've attached two files implementing a build for Win32
concerning the splitting of AP::* from mod_perl.so. They're
attached because:
- win32.diff contains some tabs needed in a Makefile
- the Makefile.PL is to go under a new directory
xs/APR/aprext/
and I wasn't sure how to do a diff with cvs for such a file
without creating the directory first, which I didn't want to
do in case there's a better location for it.
does win32 have /dev/null? that's how you'd do a diff against a new file on unix. We even have a script for that: util/getdiff.pl
Basically what's done here (all for just Win32) is to build a static library (aprext.lib) from the src/modules/perl/*.c files presently compiled into APR.so (and subsequently skip adding these files into APR.dll for Win32). APR/APR::* are then linked against this library. The library is built under xs/APR/aprext/, although that can easily be changed if desired. With this, all the tests pass (except for protocol/echo_timeout, which hangs, but this happens on unix multi-threads too, I gather). It also passes all the additional apr-ext tests I sent in a couple of recent messages, both via 'nmake test' and via 'perl t/TEST --no-httpd apr-ext'.
Looks good, Randy! The only thing I'd like to see is having those win32 problems and solutions documented (may be in Makefile.PL?).
There is one change that unix will see (although I tested it on my linux box, and everything's still OK). Unix will want to build xs/APR/aprext/, and expects a Makefile to be present after 'perl Makefile.PL'. I couldn't see how to tell it to skip this, so what this patch does for unix is to write out a Makefile with a SKIP MakeMaker attribute which skips both the dynamic and static targets, which seems to have the desired effect of nothing happening for unix. Another way to do this is to add a top-level target just for Win32, but I wasn't sure if this was desired. Of course, if there's a better way ...?
Let's leave it as you did it for now. We can change that later.
I guess once this is sorted out for Win32, we can try asking for an AIX tester, to see if similar gymnastics are needed there.
Good idea!
Great work, Randy!
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
