[EMAIL PROTECTED] wrote:
Not to be overly cute, but is there both a bb and a bb_in:

        next unless $bb_in->flatten(my $data);
-        $bb->cleanup;
+        #$bb->cleanup;


or should it have been
$bb_in->cleanup;

It's correct as it is in the test. The $bb->cleanup is needed so that we can reuse the bb w/o explicitly removing each bucket or destroying and re-creating the brigade. There is no point in cleanup of $bb_in, since it'll re-populated on get_brigade() (more over we explicitly create a new brigade, which can be also optimized to reuse bb_in as well).



-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to