I noticed on Win32 there's a problem (what else is new :) occasionally with the ModPerl-Registry/t/closure.t test; subtest 4 fails, although not in a reliable manner. I think this is due to the use of utime in the test to change the access and modification time; in perlport, it mentions that utime is unpredictable on Win32. Is using touch() of ExtUtils::Command: ==================================================== Index: ModPerl-Registry/t/closure.t =================================================================== RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/t/closure.t,v retrieving revision 1.12 diff -u -r1.12 closure.t --- ModPerl-Registry/t/closure.t 11 Jul 2004 04:29:26 -0000 1.12 +++ ModPerl-Registry/t/closure.t 11 Jul 2004 04:52:00 -0000 @@ -5,6 +5,7 @@ use Apache::TestUtil; use Apache::TestRequest; use File::Spec::Functions; +require ExtUtils::Command;
# this test tests how various registry packages cache and flush the # scripts their run, and whether they check modification on the disk @@ -128,8 +129,8 @@ # sleep() so we are more likely to have the minimal waiting time, # while fulfilling the purpose select undef, undef, undef, 1.00; # sure 1 sec - my $now = time; - utime $now, $now, $file; + my @args = ($^X, qw(-MExtUtils::Command -e touch), $file); + system(@args) == 0 or die "system @args failed: $?"; }
# if we fail to find the same interpreter, return undef (this is not
============================================================ equivalent? The doc for utime says it's equivalent to touch() if the file exists, but is this enough for the test?
It looks like it, but I don't like the use of $^X and external shell calls. How about we simply open the file for append or readwrite and then close it right away? That should be the most portable touch, no?
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
