Philippe M. Chiasson wrote:


Stas Bekman wrote:

In case you may have missed this patch on the users list, here it is again. It ties $Apache2::VERSION to $mod_perl::VERSION so one can require Apache2 for mp2. If it goes in mp1 should also be patched to do the same.


It's funny, I just peeked at Apache.pm in mp1, and it seems to specify
it's own version at 1.27 while mod_perl.pm is at 1.28 ;-)

our $VERSION = do { require mod_perl; $mod_perl::VERSION };

would also do the trick for mod_perl 1.x

Let's commit those in unison then :)

But 'our' can't be used in mp1. You must use: use vars qw($VERSION) instead.

I still want to have PAUSE support multi-generations, but this seems like a cheap workaround for the current dependency problem.

Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.164
diff -u -r1.164 Build.pm
--- lib/Apache/Build.pm    4 Jul 2004 18:44:49 -0000    1.164
+++ lib/Apache/Build.pm    12 Jul 2004 23:25:44 -0000
@@ -1752,7 +1752,12 @@
  sub generate_apache2_pm {
      my $self = shift;

- my $fixup = !$self->{MP_INST_APACHE2}
+ my $fixup = << 'EOF';
+our $VERSION = do { require Apache2; require mod_perl; $mod_perl::VERSION };
+
+EOF
+
+ $fixup .= !$self->{MP_INST_APACHE2}
? '# MP_INST_APACHE2=0, do nothing'
: <<'EOF';
BEGIN {





--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to