Randy Kobes wrote:
As it was fairly easy to do, here's an implementation
of the apr/constants test split up so that both
t/apr and t/apr-ext use the same code for the tests.

well, in the particular case of apr/constants, there is no point to have two test ways, because apr/constants.t didn't even touch modperl (it was all running on the client side already). so just moving the whole test into apr-ext/constants is probably the best approach. or even just keeping it where it is now.


in fact now that we have all the multiple tests where the constants are tested for real, this test becomes really redundant, since it may break any moment if Apache changes the corresponding values for the constants. So I consider that test obsolete and we may want to completely remove it.

+    ok ! defined &POLLIN;
+    ok t_cmp (APR::SUCCESS, 0, 'APR::SUCCESS');
+    ok t_cmp (APR::POLLIN, 0x001, 'APR::POLLIN');
+    ok t_cmp (HOOK_LAST, 20, 'HOOK_LAST');
+    ok t_cmp (APR::UNKFILE, 127, 'APR::UNKFILE');


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to