Philippe M. Chiasson wrote:
[...]
If the macro is supposed to suggest the allowed context and PerlModule is not allowed in DIR, then DIR is not appropriate. I see no problem with long names if they require no extra source code reading to figure out what they really do. These are internal macros and there are used in one place, so what's the big deal with choosing a clear name, even if it's long?


Well, there are 2 macros that must work together, so one possibility would be so call

 MP_CMD_ANYWHERE_RAW_ARGS("Perl", perldo, "Perl Code"),

And clearly at the top of the perldo implementation:
 MP_CMD_SRV_DECLARE(requires)
 {
     MP_dSCFG(parms->server);
     MP_PERL_DECLARE_CONTEXT;
     MP_CMD_SERVER_OR_HTACCESS_ONLY;

Would something like that be somewhat clearer ?

We have the following contexts:

DIR
SRV
HTACCESS

each directive can be either:

DIR
SRV
SRV + HTACCESS
DIR + HTACCESS

correct? So why not base the naming based on that?

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to