Stas Bekman wrote:
Philippe M. Chiasson wrote:
Currently, soak_end_container resides under Apache::Command, while expecting an
Apache::CmdParam as first argument. It was apparently misplaced to start with.
I suggest either moving it to Apache::CmdParams or dropping it alltogether.
+1 to move
drop it if you can't see any possible use for it. Could it be that some module creating a new container will need it? in either case, it'll trivial to add it later.
Actually, after looking at where it's being used in httpd, I am going to just drop it.
soak_end_container just slurps config up to a closing </Block> discarding everything. It's used by <IfDefine> and <IfModule> to slurp away all that in it when the condition is false.
And even if a Perl user decided to implement something vaguely similar, it could be written in 1-2 lines of Perl, or easily re-added.
So, I think it's better to just drop it for now.
-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
