Ian Holsman wrote:
The IdentityCheck directive seems to have moved to mod_ident.c in apache 2.1

One of the access tests explitly uses this directive

<Location /TestAPI__access>
    Options None
    Options Indexes FollowSymLinks
    AuthName modperl
    AuthType none
    IdentityCheck On
    SetHandler modperl
    PerlResponseHandler TestAPI::access
</Location>


Is there any way in the test config to use some kind of #ifdef or something so that it can be excluded when testing 2.1 and included with 2.0?

On the perl level yes, but I'm not sure about the config, it should be something like:


<IfDefine APACHE2_1>
   <IfDefine mod_ident.c>
      IdentityCheck On
   </IfDefine>
</IfDefine>
<IfDefine !APACHE2_1>
      IdentityCheck On
</IfDefine>

but I don't think we have that <IfDefine APACHE2_1>, Geoff?

Actually the test doesn't really check the return value at the moment:

    # XXX: this test requires a running identd, which we have no way
    # to figure out whether it's running, or how to start one. so for
    # now just check that the method is call-able.
    my $remote_logname = $r->get_remote_logname() || '';
    t_debug "get_remote_logname: $remote_logname";
    ok 1;

so it doesn't really matter whether IdentityCheck On or not.

You can safely comment it out for now.

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to