At the moment $r->document_root is a 1:1 mapping to ap_document_root, which only gives you the value, and doesn't allow you to set it.

As Dave (CC'ed) pointed out, some people already want to use it as they did in mp1, i.e. set it to some value.

The problem of allowing the setting of doc_root (forgetting to reset it back) was always there, now it's got even worse. Even if you handle all the aspects of locking under threads, changing the server config structure will affect all threads, doesn't it? In which case it's a no-no (at least for threads).

So far the previous discussions on this topic were:
http://mathforum.org/epigone/modperl-dev/pehcroner/[EMAIL PROTECTED]
http://mathforum.org/epigone/modperl-dev/swirelplu

So what should we do about it?

I suppose we could make it get/set at startup time and get/set at all times for non-threaded mpms and only get for threaded mpms, like we did with a few other struct accessors (to see those run):

grep -Ir '\$' xs/maps/

it sounds like document_root falls into the same group as all the accessors above. Or doesn't it?

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to