On Thu, Sep 02, 2004 at 05:44:19PM -0400, Geoffrey Young wrote:
> 
> 
> [EMAIL PROTECTED] wrote:
> > stas        2004/08/25 10:20:11
> > 
> >   Modified:    lib/Apache Build.pm
> >                .        Changes
> >   Log:
> >   fix the modperl build, where httpd has been built against separate
> >   installations of apr-util and apr, where apr-util has been installed
> >   with a different includedir to apr.
> >   Submitted by:     Joe Orton
> 
> hey joe :)
> 
> did this patch alone really solve the problem for you?  I can't get mod_perl
> to compile against httpd-2.1-rc1 with an external apr/apu.

Oh, no, it doesn't work :(.  I swear I tested this, but I guess I forgot
to revert the other changes in the patch properly.

It's not picking up apu-config properly because it looks in APR_BINDIR
rather than APU_BINDIR.  This *really* fixes it:

Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvspublic/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.172
diff -u -r1.172 Build.pm
--- lib/Apache/Build.pm 25 Aug 2004 17:20:00 -0000      1.172
+++ lib/Apache/Build.pm 3 Sep 2004 06:01:50 -0000
@@ -975,6 +975,7 @@
 
     my $key = "${what}_config_path"; # apr_config_path
     my $mp_key = "MP_" . uc($what) . "_CONFIG"; # MP_APR_CONFIG
+    my $bindir = uc($what) . "_BINDIR"; # APR_BINDIR
 
     return $self->{$key} if $self->{$key} and -x $self->{$key};
 
@@ -993,7 +994,7 @@
         }
         else {
             push @tries, grep length,
-                map $self->apxs(-q => $_), qw(APR_BINDIR BINDIR);
+                map $self->apxs(-q => $_), $bindir, "BINDIR";
             push @tries, catdir $self->{MP_AP_PREFIX}, "bin"
                 if exists $self->{MP_AP_PREFIX} and -d $self->{MP_AP_PREFIX};
         }

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to