Geoffrey Young wrote:
hi all

I just did a fresh checkout and forgot to copy my makepl_args.modperl2 file
over to the new directory.  when I built mod_perl with

  $ perl Makefile.PL MP_APXS=apxs

I got both the following warnings at the same time:

[warning] mod_perl dso library will be built as mod_perl.so
[warning] mod_perl static library will be built as mod_perl.a

Yes, I remember running into this when I originally worked on the static build. It's probably in the archives somewhere, but what I remember is that it was an intended feature to have both mod_perl.so and mod_perl.a built by default, so that httpd could be statically linked against that mod_perl.a in the future.

I didn't think it was necessary either, but for some reason, someone pointed
out a good reason to keep it the way it was.

and mod_perl built as a DSO.

I think the attached patch is all that is required to clean things up if we
want DSO to be the default build (which it currently is).

I think this patch would be fine.

--Geoff


------------------------------------------------------------------------

Index: lib/ModPerl/BuildOptions.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/ModPerl/BuildOptions.pm,v
retrieving revision 1.28
diff -u -r1.28 BuildOptions.pm
--- lib/ModPerl/BuildOptions.pm 23 Jul 2004 23:24:55 -0000 1.28
+++ lib/ModPerl/BuildOptions.pm 1 Sep 2004 19:15:24 -0000
@@ -55,7 +55,8 @@
}
unless ($build->{MP_USE_DSO} or $build->{MP_USE_STATIC}) {
- $build->{MP_USE_DSO} = $build->{MP_USE_STATIC} = 1;
+ # default to DSO
+ $build->{MP_USE_DSO} = 1;
}
$build->{MP_GENERATE_XS} = 1 unless exists $build->{MP_GENERATE_XS};



------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Attachment: signature.asc
Description: OpenPGP digital signature



Reply via email to