Rici Lake wrote:
On 9-Sep-04, at 12:50 PM, Philippe M. Chiasson wrote:
Incredibly thorough bug reporting, many thanks.
We aim to please ;)
You correctly identified a leak and can you give the following patch a spin and let me know if it plugs it?
The patch fixes the override problem but it seems to still be leaking memory.
Fixing the override problem was a nice planned side-effect of this patch.
I had to download the current CVS snapshot to apply it; I see that the problems with building on FreeBSD have now been resolved, which is great
Anyway, I patched the CVS snapshot to set override to OR_ALL rather than the initial settings, so that my little .htaccess file could run without generating errors. Then I ran roughly the same ab test as I did before, on both the CVS snapshot and the CVS snapshot with your patch.
(ab -c 4 -n 100000)
This pretty well maxes out a 100Mb ethernet (even though the file itself is tiny) so ab is not very helpful in terms of speed measures, but running top at the same time lets me check out memory usage. The children start out at 9.2 MB (size, not rss -- in all cases rss stays pretty constantly at size - 3 MB). With the current snapshot, the children end up being between 25 MB and 29.5 MB (and the server starts to swap by the end of the test, my test machine only has 512 MB). With your patch, this comes down to 18-23 MB. So the leakage was about 18 MB/child before your patch, and 11.3 MB/child with your patch.
Hrm, that's unfortunate it doesn't fully plug the leak.
I'd say that's a big step forward: Override settings are obviously important and the memory leakage is significantly reduced. (The slight increase in response time was probably the result of not driving the machine into swap.)
Where the rest of the memory is going, I don't know. Maybe the perl environments are expanding?
That's a possibility I'll look into. I will be checking this leak fix shortly along with another fix to the way package are unloaded and it might help reduce this leaking as well.
Once I checked both fixes in, you could try your test once more and report on the leaks it generates.
Thanks!
R.
-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
