Steve Hay wrote: [...]
OK, the attached patch (against httpd-2.0.50) gets things (mostly) working for me.
I dropped the check for (*new_file)->buffered that the unix case has because the win32 case always sets it to FALSE so the new if { ... } block would not have been entered. (I considered copying ->buffered from the old_file like unix does, but it was FALSE on the old_file too.)
I also dropped the !(*new_file)->mutex test that the unix case has because on win32 we've always just done a apr_pcalloc() on the *new_file, so we know ->mutex is NULL.
There's also a apr_file_dup2() in the win32 file. I don't know if that needs fixing up similarly.
Most likely. Look at the unix implementation, it should be similar.
Should I send this patch somewhere else for consideration?
Yes, to the apr-dev list.
I tried starting apache.exe with each of the MOD_PERL_TRACE flags in turn. Previously d, e, f, g, h, i, o and r all caused a crash. Now they all work OK except for g (globals) which still causes a crash:
NTDLL! 77f69ecd()
NTDLL! 77f5b2e6()
apr_file_write(apr_file_t * 0x009e0268, const void * 0x009ed6b8, unsigned int * 0x0006de94) line 274
apr_file_puts(const char * 0x009ed6b8, apr_file_t * 0x009e0268) line 399
apr_file_printf(apr_file_t * 0x009e0268, const char * 0x100363ec `string') line 475 + 13 bytes
modperl_trace(const char * 0x100331b4 `string', const char * 0x100331cc `string') line 51 + 22 bytes
modperl_global_cleanup(void * 0x100373bc MP_global_server_rec) line 79 + 34 bytes
run_cleanups(cleanup_t * * 0x0029acf8) line 1951 + 13 bytes
apr_pool_clear(apr_pool_t * 0x0029ace8) line 693 + 12 bytes
main(int 9, const char * const * 0x00292918) line 576
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e814c7()
Don't know what the top two frames there are. They both show up as "Disassembly" in the debugger :( The apr_file_t * in apr_file_write() does have a mutex, though.
NT in NTDLL is for native threads? May be something else is broken. Ask at the apr-dev list?
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
